This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Handle both hangup and detach events #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
reviewed
Aug 5, 2020
| inev: &E, | ||
| evp: &IncomingEventProperties, | ||
| ) -> Result<MessageStream, SvcError> { | ||
| let rtc_stream_id = Uuid::from_str(inev.opaque_id()) |
There was a problem hiding this comment.
parse::<HandleId>(inev.opaque_id()).rtc_stream_id()
?
There was a problem hiding this comment.
No, this is correct. Opaque id really contains the stream id.
feymartynov
force-pushed
the
feature/ULMS-620
branch
from
b0a6d11
to
a4e8bd6
Compare
manifest
approved these changes
Aug 6, 2020
khodzha
approved these changes
Aug 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.