Add parameter support #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
force-pushed
the
achim/parameter_support
branch
2 times, most recently
from
c2362ea
to
5a2b275
Compare
achim-k
force-pushed
the
achim/parameter_support
branch
3 times, most recently
from
c6db7cc
to
96e67cb
Compare
jhurliman
reviewed
Jan 4, 2023
|
|
||
| auto executor = | ||
| rclcpp::executors::MultiThreadedExecutor::make_shared(rclcpp::ExecutorOptions{}, numThreads); | ||
|
|
||
| rclcpp_components::ComponentManager componentManager(executor, "ComponentManager"); | ||
| rclcpp_components::ComponentManager componentManager(executor, "foxglove_component_manager"); |
There was a problem hiding this comment.
This may need to be foxglove_bridge_component_manager if it's supposed to be globally unique in the rosgraph, since we may introduce more Foxglove ROS nodes over time.
There was a problem hiding this comment.
Changed during rebasing. Since #125 we could actually get rid of the executable, since one can load the compoment directly in a launch file: https://docs.ros.org/en/humble/How-To-Guides/Launching-composable-nodes.html
jhurliman
approved these changes
Jan 4, 2023
achim-k
force-pushed
the
achim/parameter_support
branch
from
d14becf
to
3e84a46
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Implements support for parameters which was added to the ws-protocol specification in foxglove/ws-protocol#288
This PR is rather big due to the different implementation of parameters for ROS 1 and ROS 2
ROS 1:
ros::NodeHandle::getParamNames,ros::NodeHandle::getParam,ros::NodeHandle::setParamROS 2 (see also About-ROS-2-Parameters):
list_parameters,get_parameters,set_parametersFixes #9
FG-1203