Add ROS1 support for calling server-advertised services #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
force-pushed
the
achim/services
branch
3 times, most recently
from
fc7123f
to
d6c13cc
Compare
achim-k
force-pushed
the
achim/services
branch
from
d6c13cc
to
9bb5ce1
Compare
achim-k
changed the title
achim-k
changed the title
jhurliman
reviewed
Jan 26, 2023
jhurliman
approved these changes
Feb 7, 2023
achim-k
added a commit
that referenced
this pull request
Feb 7, 2023
**Public-Facing Changes** - Add ROS2 support for calling server-advertised services **Description** Based on #136 - Adds experimental ROS2 support for advertising/unadvertising services and allowing clients to call them - Implements the services spec that was added in foxglove/ws-protocol#344 Implementation details: The main problem is, that symbols from getting the service type support are missing from the `rosidl_typesupport_cpp` libraries that are generated for each msg/srv package (see ros2/rosidl_typesupport#122). There is an open pull request (ros2/rosidl_typesupport#114) to fix that, but so far it hasn't been merged. I found a working, yet little bit hacky, workaround for this problem which is described more in detail here: https://github.com/foxglove/ros-foxglove-bridge/blob/f978c182185e5deda93a6518132b6d3c339dcaeb/ros2_foxglove_bridge/src/generic_client.cpp#L59-L89 All in all, the implementation is working, but I would consider it as experimental for now. I am not sure if this approach would work on windows / mac
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Implementation details:
GenericService) when one defines theros::service_traitsandros::serializationtraitsFixes #10 (together with #142)