Add ROS2 support for calling server-advertised services #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Based on #136
Implementation details:
The main problem is, that symbols from getting the service type support are missing from the
rosidl_typesupport_cpp
libraries that are generated for each msg/srv package (see ros2/rosidl_typesupport#122). There is an open pull request (ros2/rosidl_typesupport#114) to fix that, but so far it hasn't been merged.I found a working, yet little bit hacky, workaround for this problem which is described more in detail here:
ros-foxglove-bridge/ros2_foxglove_bridge/src/generic_client.cpp
Lines 59 to 89 in f978c18
All in all, the implementation is working, but I would consider it as experimental for now. I am not sure if this approach would work on windows / mac