Add support for schemaEncoding field
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Mar 8, 2023
Comment on lines
+19
to
+22
| const auto schemaEncoding = | ||
| j.find("schemaEncoding") == j.end() | ||
| ? std::optional<std::string>(std::nullopt) | ||
| : std::optional<std::string>(j["schemaEncoding"].get<std::string>()); |
There was a problem hiding this comment.
nit
Suggested change
| const auto schemaEncoding = | |
| j.find("schemaEncoding") == j.end() | |
| ? std::optional<std::string>(std::nullopt) | |
| : std::optional<std::string>(j["schemaEncoding"].get<std::string>()); | |
| const std::optional<std::string> schemaEncoding = | |
| j.find("schemaEncoding") == j.end() | |
| ? std::nullopt | |
| : j["schemaEncoding"].get<std::string>(); |
There was a problem hiding this comment.
Also initially tried that, but CPP is rather strict and complains that the types in the branches (not sure what the correct term is) differs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
schemaEncodingfieldDescription
Implements the specification update in foxglove/ws-protocol#385
Fixes #8