Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log version and commit hash when node is started #209

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Log version and commit hash when node is started #209

merged 2 commits into from
Apr 6, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Apr 5, 2023

Public-Facing Changes

  • Log ROS distro, version and git commit hash when starting node

Description

Logs additional version information to make it easier to debug user problems

Examples:

# With uncommited changes
Starting foxglove_bridge (galactic, 0.5.3@83cc834577-dirty) with WebSocket++/0.8.1
Starting foxglove_bridge (noetic, 0.5.3@83cc834577-dirty) with WebSocket++/0.8.1

# Without changes
Starting foxglove_bridge (galactic, 0.5.3@a685b31baf) with WebSocket++/0.8.1

Fixes #197

@achim-k achim-k requested a review from jtbandes April 5, 2023 19:02
jtbandes
jtbandes approved these changes Apr 6, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@achim-k achim-k enabled auto-merge (squash) April 6, 2023 14:13
@achim-k achim-k merged commit cf0a977 into main Apr 6, 2023
@achim-k achim-k deleted the achim/fg-2446_log_version_and_git_hash branch April 6, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log foxglove_bridge version at startup
2 participants
@achim-k @jtbandes