Communicate double / double array parameters with type info, explicitly cast when set from integer #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In reviewing this PR I realized I should have read the spec changes more clearly. I have some questions here: foxglove/ws-protocol#519 (comment) In what direction do we need to communicate this type information? Is this from server -> client (studio)? |
achim-k
added a commit
to foxglove/studio
that referenced
this pull request
Aug 16, 2023
**User-Facing Changes** Not worth being mentioned in release notes **Description** When setting a float parameter to e.g. `1.0`, Javascript automatically makes it to `1` and the server would deduce this as a integer parameter. Remembering the parameter type that is communicated by the server, and sending it along with a `setParameter` request fixes this. See also foxglove/ws-protocol#519 and foxglove/ros-foxglove-bridge#256 Fixes #6559
jtbandes
reviewed
Aug 21, 2023
jtbandes
approved these changes
Aug 21, 2023
achim-k
force-pushed
the
achim/support_float_parameter_types
branch
from
362ca07
to
9c3b50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Communicate double / double array parameters with type info, explicitly cast when set from integer
Description
Implements foxglove/ws-protocol#519
PARAMETER_DOUBLE("type": "float64") or anPARAMETER_ARRAYofPARAMETER_DOUBLE("type": "float64_array")setParametersrequest from the client, the server checks if the parametertypefield is present and attempts to cast the parameter value (or values in case it's an array) to adoublein case the type isfloat64/float64_array. This is mainly relevant for ROS2 as setting a double parameter to an integer will raise an exception. In ROS1, one can change the parameter type on the fly