This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
foxglove websocket: Remember parameter types #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
requested review from
jtbandes,
defunctzombie and
snosenzo
and removed request for
jtbandes
snosenzo
reviewed
Aug 9, 2023
There was a problem hiding this comment.
I imagine this is related to the float64 and float64_array type additions, but from the description and the code it's hard to see how just passing the type with the parameter allows the receiver to properly cast 1 to 1.0. Where does this conversion happen? Is something already looking for float64 to cast it?
This is done on the server side. The server casts integers to doubles if the type is |
snosenzo
approved these changes
Aug 9, 2023
jtbandes
approved these changes
Aug 16, 2023
achim-k
deleted the
achim/fg-4486-setting-parameter-of-type-double-to-10-throws-type-error
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Not worth being mentioned in release notes
Description
When setting a float parameter to e.g.
1.0, Javascript automatically makes it to1and the server would deduce this as a integer parameter. Remembering the parameter type that is communicated by the server, and sending it along with asetParameterrequest fixes this.See also foxglove/ws-protocol#519 and foxglove/ros-foxglove-bridge#256
Fixes #6559