Add ROS 2 dependency for ament_index_cpp #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a direct dependency in this package to ament_index_cpp, so make sure to add it.
|
|
|
The smoke test failed on the Rolling build, but that seems unrelated to this pull request. |
achim-k
approved these changes
Dec 28, 2023
|
Thanks for merging! When you get a chance, a new release into Rolling should fix the build there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
None
Description
There is a direct dependency in this package to ament_index_cpp, so make sure to add it.
This should fix the failing build on Rolling: https://build.ros2.org/view/Rbin_uJ64/job/Rbin_uJ64__foxglove_bridge__ubuntu_jammy_amd64__binary/89/