Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop spamming our contact form with buildfarm notifications #104

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Dec 2, 2022

No description provided.

Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably use the ros-tooling@foxglove.dev group which we made for this purpose. Whether John & Achim want to be listed individually as author/maintainer is up to them; personally I've liked to maintain plausible deniability for my own involvement in our published packages 😄

@achim-k
Copy link
Collaborator

achim-k commented Dec 2, 2022

I believe that emails are only sent to maintainers, not authors. So #70 should have fixed this problem. Old release builds might still send emails to contact@foxglove.com but those should fade out soon.

I think we should probably use the ros-tooling@foxglove.dev group which we made for this purpose

That's a good idea. Maybe we could make it even ros-tooling+foxglove_bridge@foxglove.dev, so mail traffic for that project can be forwarded easily to the corresponding developers

@amacneil
Copy link
Contributor Author

amacneil commented Dec 4, 2022

I don't mind where they get sent, but contact@foxglove.dev should not be hooked up to any automated notifications (it goes to our sales inbox). We were still getting like 20 emails/day as of Thursday so I don't think #70 worked.

@achim-k achim-k enabled auto-merge (squash) December 5, 2022 17:21
@achim-k achim-k requested a review from jtbandes December 5, 2022 17:25
@achim-k achim-k disabled auto-merge December 5, 2022 17:25
@jtbandes jtbandes merged commit daee44a into main Dec 5, 2022
@jtbandes jtbandes deleted the adrian/authoremail branch December 5, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants