Make server capabilities configurable #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean the websocket_server code will need to look at this list of capabilities to decide what features to toggle on/off? |
jhurliman
approved these changes
Dec 13, 2022
+1, seems like it could make sense to have a server configuration where you can toggle client publishing on/off, and the server translates that to a capability? Or what were you envisioning? |
Yes, the server will have to check if an operation is allowed to be called based on its capabilities. Is this what you mean? |
jhurliman
pushed a commit
that referenced
this pull request
Dec 14, 2022
**Public-Facing Changes** - Publish binary time data when `use_sim_time` is `true` **Description** Depends on foxglove/ws-protocol#299 - When the `use_sim_time` parameter is set - The server advertises the `time` capability - It subscribes to the `/clock` topic and broadcasts binary time messages - I have removed the code that detects presence of the `/clock` topic, since now it has to be known at startup whether `use_sim_time` is true or false - Includes #115 (will rebase after it got merged)
|
Closing as this got merged with #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
None
Description