Drop messages when connection send buffer limit has been reached #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
commented
Dec 23, 2022
foxglove_bridge_base/include/foxglove_bridge/websocket_server.hpp
Outdated
Show resolved
Hide resolved
jhurliman
approved these changes
Jan 3, 2023
jhurliman
reviewed
Jan 3, 2023
| if (bufferSizeinBytes >= _send_buffer_limit_bytes) { | ||
| _server.get_elog().write(WARNING, | ||
| "Send buffer for client '" + remoteEndpointString(clientHandle) + | ||
| "' is full, dropping message on channel " + std::to_string(chanId)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
We currently do have the problem that slow clients/connections can cause the server's connection send buffer to grow indefinitely potentially leading to the server being killed as it consumes too much memory. This PR introduces a user configurable send buffer limit. If the limit has been reached, messages that are to be send over this connection will be dropped in order to prevent the send buffer growing indefinitely.
See also #116