Fix publishers being created with invalid QoS profile #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Since #184 we use the QoS profile of an existing publisher when creating a new publisher for a client advertised topic. In case the existing publisher has been destroyed before (but is still registered, see #204), the QoS profile is invalid and creating a publisher fails with the message
'create_publisher() failed setting topic QoS, at ./src/publisher.cpp:226'
.This PR mitigates the issue by taking the QoS profile of an existing publisher from a different node (if there is any). The assumption is, that publishers of other nodes are less likely to be destroyed.