Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume publisher qos depth of 1 if the middleware reports the qos history as unknown #239

Merged
merged 4 commits into from Jul 5, 2023
Merged

Assume publisher qos depth of 1 if the middleware reports the qos history as unknown #239

merged 4 commits into from Jul 5, 2023

Commits on Jun 30, 2023

  1. Add test with multiple transient local publishers

    @achim-k
    achim-k committed Jun 30, 2023
    Copy the full SHA
    29161f0 View commit details
    Browse the repository at this point in the history

  2. Assume a publisher qos depth of 1 if RMW does not store the history d… 

    …epth

Some RMWs do not retrieve history information of the publisher endpoint
in which case the history depth is 0. We use a lower limit of 1 here,
so that the history depth is at least equal to the number of publishers.
This covers the case where there are multiple transient_local publishers
with a depth of 1 (e.g. multiple tf_static transform broadcasters).
See also
#238 and
#208
    @achim-k
    achim-k committed Jun 30, 2023
    Copy the full SHA
    331835d View commit details
    Browse the repository at this point in the history

  3. Increase default max qos depth to 25

    @achim-k
    achim-k committed Jun 30, 2023
    Copy the full SHA
    b07472c View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. warn if calulcated qos depth is limited by max_qos_depth param value

    @achim-k
    achim-k committed Jul 3, 2023
    Copy the full SHA
    6445132 View commit details
    Browse the repository at this point in the history