This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Fix parsing/serialization of Timestamp, use fractional seconds instead of nanoseconds #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Feb 17, 2022
| @@ -1,7 +1,7 @@ | |||
| import { Participant, selectIPv4, Durability, Reliability, HistoryKind } from "../src"; | |||
| import { getNetworkInterfaces, UdpSocketNode } from "../src/nodejs"; | |||
|
|
|||
| const DURATION_INFINITE = { sec: 0x7fffffff, nsec: 0xffffffff }; | |||
| const DURATION_INFINITE = { sec: 0x7fffffff, nsec: 999999999 }; | |||
jtbandes
reviewed
Feb 17, 2022
| * @returns Nanoseconds integer | ||
| */ | ||
| export function fractionToNanoseconds(fraction: number): number { | ||
| return Math.trunc(Number((BigInt(fraction) * 1_000_000_000n) / 4_294_967_296n)); |
There was a problem hiding this comment.
What's the point of Math.trunc when we just did integer division before converting to Number?
There was a problem hiding this comment.
Good catch. I keep forgetting BigInt is actually an integer, not floating-point like Number.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.