Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frame_id to LocationFix #100

Closed
jhurliman opened this issue Mar 30, 2023 · 2 comments · Fixed by #108
Closed

Add frame_id to LocationFix #100

jhurliman opened this issue Mar 30, 2023 · 2 comments · Fixed by #108

Comments

@jhurliman
Copy link
Contributor

Description

Although the Map panel doesn't do anything with the frame_id of a GPS point today, adding this field would make it possible to write a User Script or Message Converter that places a GPS point in 3D space (scene entity with pose at the origin, frame_id = gps frame_id, frame_locked = false).
@jhurliman jhurliman added the bug Something isn't working label Mar 30, 2023
@foxhubber
Copy link

foxhubber bot commented Mar 30, 2023

Internal tracking ticket: FG-2726

@defunctzombie defunctzombie removed the bug Something isn't working label Mar 30, 2023
@defunctzombie defunctzombie mentioned this issue May 9, 2023
Merged
@defunctzombie
Copy link
Contributor

Please take a look at the proposed field description: #108 and provide feedback.

defunctzombie added a commit that referenced this issue May 11, 2023
@defunctzombie
Add a frame_id field to LocationFix (#108)
f8d19d0 
The frame_id field for the LocationFix message specifies the frame for
the origin of the sensor so the lat/lon values can be tied to a location
on the robot.

Fixes: #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a frame_id field to LocationFix foxglove/schemas
2 participants
@defunctzombie @jhurliman