Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending PointsAnnotation and CircleAnnotation with object_id #107

Conversation

markoSyrmia
Copy link

@markoSyrmia markoSyrmia commented May 5, 2023

I have added object_id in PointsAnnotation and CircleAnnotation.

Description

I need this change because i want to have possibility to send object id through protobuf message, in order to be able to display it on ImageView. This is only the first part, the second is contained in foxglove/studio repo.

I will post here link of PR (the second part from foxglove/studio repo), for better understanding why i need this changes.
https://github.com/foxglove/studio/pull/5921

@CLAassistant
Copy link

CLAassistant commented May 5, 2023

CLA assistant check
All committers have signed the CLA.

@jtbandes
Copy link
Member

Hi,
What is the intended use case for the object id? I noticed that your other PR #109 references the object id being a simple label like "car" or "truck". Is it just a visual label, or do you want to tie the identifier to a particular instance of data?

@markoSyrmia
Copy link
Author

To an extent the answer is Yes on bot counts. We wanted to implement the ability to "render" the object ID on screen, and also have it share object ID with other representations of the data in other views. So that the user can identify that the rectangle in Image view is the same object as a cube in 3D view.

@jtbandes
Copy link
Member

For rendering the object ID on screen, have you tried TextAnnotation?
For displaying additional data, would adding a metadata field (similar to SceneEntity) work for your use case?

@jtbandes
Copy link
Member

We believe that TextAnnotations are the best way to achieve this feature.

@jtbandes jtbandes closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants