Generate .idl schemas #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
reviewed
Aug 28, 2023
| @@ -17,8 +17,8 @@ export const exampleEnum: FoxgloveEnumSchema = { | |||
| parentSchemaName: "ExampleMessage", | |||
| description: "An example enum", | |||
| values: [ | |||
| { name: "A", value: 1, description: "Value A" }, | |||
| { name: "B", value: 2, description: "Value B" }, | |||
| { name: "A", value: 0, description: "Value A" }, | |||
There was a problem hiding this comment.
Is it worth putting a comment here that these need to start at 0 for omgidl enum support?
There was a problem hiding this comment.
I think it's fine without since the assertion will catch it if this were to change
|
Another thought, should we test this against |
|
Not sure if there is anything specific you would like me to review, but I took a look at a few of the generated schemas and they seem good. |
snosenzo
approved these changes
Aug 28, 2023
snosenzo
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OMG IDL definitions for Foxglove schemas.