Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Percieved Choppyness in Plot panel once a second due to rounding. #7444

Closed
antrose99 opened this issue Feb 4, 2024 · 2 comments
Closed

Percieved Choppyness in Plot panel once a second due to rounding. #7444

antrose99 opened this issue Feb 4, 2024 · 2 comments
Labels
bug The user is unable to complete a supported task, or the software does not behave as intended

Comments

@antrose99
Copy link

Description
When using the plot panel to visualize a topic over a connection a visible choppiness happens once a second due to a weird rounding of the timestamp. All timestamps (or time since start of connection) get rounded to 1 decimal, for instance 252.222 would get rounded to 252.2. However, if the timestamp has a 0 as the first decimal, then an additional decimal gets displayed, e.g. 252.01112 becomes 252.01. This causes a noticeable choppiness as the plot window is resized to fit this extra decimal.

An example of this can be seen in the following gif (although perhaps not super clearly due to compression): https://imgur.com/L1CLaC4

  • Version: 1.86.1
  • Platform: Linux
  • Data source (e.g. bag file, mcap file, rosbridge, ROS 1/2 native): Foxglove Bridge

Steps To Reproduce
Open a connection, open the plot panel and visualize any topic

Expected Behavior
Instead round the timestamp to be 1 decimal regardless, ensuring that these resizes happen less frequently (i.e. only at 1->10, 10->100, 100->1000 etc)

@antrose99 antrose99 added the bug The user is unable to complete a supported task, or the software does not behave as intended label Feb 4, 2024
@foxhubber
Copy link

foxhubber bot commented Feb 4, 2024

Internal tracking ticket: FG-6517

@antrose99
Copy link
Author

Saw that a pull request fixing this has already been submitted (#7419), closing:)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug The user is unable to complete a supported task, or the software does not behave as intended
Development

No branches or pull requests

1 participant