Added Static typings #277
Open
Added Static typings #277
+79
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
| _auth_input_props.push_back(pe) | ||
| for picked_property in input_properties: | ||
| picked_property_entry = _property_cache.get_entry(picked_property) | ||
| _record_input_props.push_back(picked_property_entry) |
There was a problem hiding this comment.
Note that _record_input_props is set here outside authority. Solves #250 and its tested to work locally, as intended in all my other PRs. After all, it is not set anywhere if not here, and before this commit, _record_input_props is the same as _auth_input_props for exclusively the authority player, which makes _record_input_props obsolete to _auth_input_props.
And as mentioned elsewhere, this change is how _auth_state_props and _record_state_props works, so I see this as a bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only non-static typing in this PR is the handling of
_record_input_propsas its just 1 line and solves #250As for the version bump for each PR, I suggest implementing git hooks which automatically upgrade those values after each PR, because that is the only conflict here (I resolved it, but this has version 1.8.4 just like #276 but I guess if both are merged its good, I will resolve merge conflicts if any)