Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for latest genproto version #47

Merged
merged 2 commits into from Mar 12, 2023

Conversation

staktrace
Copy link
Contributor

@staktrace staktrace commented Mar 9, 2023

Update our dependencies to be compatible with the current latest release
of google.golang.org/genproto by running:

go get google.golang.org/genproto
go mod tidy

This has broken a couple of small things, which are fixed here:

Link: grpc/grpc-go#5799
Link: grpc/grpc-go#5292

Generated by running:
  go get google.golang.org/genproto
  go mod tidy
@camh-
Copy link
Member

camh- commented Mar 9, 2023

Hey, thanks for your contribution @staktrace. I'll get this merged over the weekend. FYI, I'll squash merge since I prefer atomic commits, and for that, I'll re-write the PR title/description as that is used as the basis of the merge commit by my merge script. I want to see what they changed in proto gen stuff for why this var got renamed and if there might be other consequences.

@juliaogris
Copy link
Member

Hi @staktrace - so nice to see your contribution, I hope things are well.
I unblocked the CI run, looks like it failed. You can run CI locally in activated hermit env with make ci.

Looks like a variable in an upstream package got renamed.
@staktrace
Copy link
Contributor Author

Thanks! It looks like the CI was failing because one of the error messages changed as well. I've updated the PR such that make ci now passes for me locally.

And feel free to edit the PR as needed!

@camh- camh- changed the title Update dependencies Update dependencies for latest genproto version Mar 12, 2023
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'll squash the two commits together as I prefer that all commits can pass CI, so the deps update needs to be combined with the code changes. I've updated the PR description to include the info from the commits as that will become the squash merge commit message.

@camh- camh- merged commit 32bea44 into foxygoat:master Mar 12, 2023
2 checks passed
@staktrace
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants