Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to install #28

Closed
tfausak opened this issue Apr 20, 2015 · 9 comments
Closed

Failed to install #28

tfausak opened this issue Apr 20, 2015 · 9 comments
Assignees

Comments

@tfausak
Copy link

tfausak commented Apr 20, 2015

I tried to install version 0.0.0 on OS X 10.10.3 with GHC 7.8.3 and Cabal 1.22.2.0. It complains that endOfLine is not in scope.

$ uname -a
Darwin mbafo.local 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64
$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 7.8.3
$ cabal --version
cabal-install version 1.22.2.0
using version 1.22.2.0 of the Cabal library 
$ date
Mon Apr 20 08:03:43 CDT 2015
$ cabal update
Downloading the latest package list from hackage.haskell.org
Skipping download: Local and remote files match.

$ cabal install stackage-cli-0.0.0
...
[2 of 2] Compiling Main             ( main/Purge.hs, dist/build/stackage-purge/stackage-purge-tmp/Main.o )

main/Purge.hs:101:23: Not in scope: ‘endOfLine’

main/Purge.hs:107:67: Not in scope: ‘endOfLine’
cabal: Error: some packages failed to install:
stackage-cli-0.0.0 failed during the building phase. The exception was:
ExitFailure 1

Here is the offending line: https://github.com/fpco/stackage-cli/blob/0.0.0/main/Purge.hs#L107. The endOfLine parser comes from Text.Parsec.Char. I don't think it's available in parsec 3.1.5, which Cabal decided to use.

@snoyberg
Copy link
Member

Thanks for the report. @DanBurton Can you look into this?

@DanBurton
Copy link
Contributor

Yep. Looks like we need a lower bound constraint on Parsec, or I can rewrite that particular parser.

@snoyberg
Copy link
Member

The function's pretty short:

endOfLine :: (Stream s m Char) => ParsecT s u m Char
endOfLine           = newline <|> crlf       <?> "new-line"

How about conditionally including it?

@DanBurton
Copy link
Contributor

This should now be resolved with 0.0.0.2 on Hackage, can you confirm?

@tfausak
Copy link
Author

tfausak commented Apr 20, 2015

Unfortunately it still fails.

$ cabal install stackage-cli-0.0.0.2
...
[2 of 2] Compiling Main             ( main/Purge.hs, dist/build/stackage-purge/stackage-purge-tmp/Main.o )

main/Purge.hs:104:25: Not in scope: ‘crlf’
cabal: Error: some packages failed to install:
stackage-cli-0.0.0.2 failed during the building phase. The exception was:
ExitFailure 1

@DanBurton
Copy link
Contributor

Whoops, sorry about that.

I tested on my machine this time:

$ git clone git@github.com:fpco/stackage-cli
$ cd stackage-cli
$ cabal sandbox init # you can skip this part
$ cabal install --constrait 'parsec<3.1.6'

@snoyberg can you double check?

@snoyberg
Copy link
Member

Looks good to me, just compiled with parsec-3.1.5. Please go ahead and release.

@DanBurton
Copy link
Contributor

Uploaded 0.0.0.3 to hackage. @tfausak it should at least make it past these parsec errors now. Can you confirm?

@tfausak
Copy link
Author

tfausak commented Apr 20, 2015

👍 That did the trick. Thank you for the fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants