Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS instead of HTTP #34

Merged
merged 2 commits into from
Apr 22, 2015
Merged

Use HTTPS instead of HTTP #34

merged 2 commits into from
Apr 22, 2015

Conversation

snoyberg
Copy link
Member

Also note usage of www. Bare domains redirect to www, so it's better to
avoid the extra HTTP roundtrip.

Pinging @chrisdone

Also note usage of www. Bare domains redirect to www, so it's better to
avoid the extra HTTP roundtrip.
@DanBurton
Copy link
Contributor

👍

This is currently the only web request that stackage sends. I'll be mindful when working on stackage-setup to use https as appropriate.

n.b. The cabal.config file still says -- Stackage snapshot from: http://www.stackage.org/snapshot/[blah] (note the http), and main/Sandbox.hs currently depends on this precise string being present as a quick (and imprecise) verification that a local cabal.config came from stackage. Both of these things can be easily changed, I just wanted to note the status quo.

@DanBurton
Copy link
Contributor

I verified on my machine that stackage init still correctly retrieves cabal.config files from stackage.org. @snoyberg I presume you did the same? Ready for merge?

@snoyberg
Copy link
Member Author

Yes this is ready for merge.

On Wed, Apr 22, 2015, 8:55 PM Dan Burton notifications@github.com wrote:

I verified on my machine that stackage init still correctly retrieves
cabal.config files from stackage.org. @snoyberg
https://github.com/snoyberg I presume you did the same? Ready for merge?


Reply to this email directly or view it on GitHub
#34 (comment).

DanBurton added a commit that referenced this pull request Apr 22, 2015
Use HTTPS instead of HTTP
@DanBurton DanBurton merged commit ff3adb3 into master Apr 22, 2015
@DanBurton DanBurton deleted the https branch April 22, 2015 19:00
@DanBurton
Copy link
Contributor

Merged and uploaded to hackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants