Skip to content

Commit

Permalink
pylint: enable various optional checks/extensions
Browse files Browse the repository at this point in the history
  • Loading branch information
fphammerle committed Jun 5, 2022
1 parent fd0d0b6 commit d551dd4
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 2 deletions.
24 changes: 22 additions & 2 deletions .pylintrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
[MESSAGE CONTROL]
[MASTER]

disable=missing-function-docstring,
load-plugins=pylint.extensions.check_elif,
pylint.extensions.comparison_placement,
pylint.extensions.confusing_elif,
pylint.extensions.consider_ternary_expression,
pylint.extensions.emptystring,
pylint.extensions.eq_without_hash,
pylint.extensions.for_any_all,
pylint.extensions.mccabe,
pylint.extensions.no_self_use,
pylint.extensions.overlapping_exceptions,
pylint.extensions.private_import,
pylint.extensions.redefined_loop_name,
pylint.extensions.redefined_variable_type,
pylint.extensions.set_membership,
pylint.extensions.typing

[MESSAGES CONTROL]

disable=consider-alternative-union-syntax, # requires python>=3.10
deprecated-typing-alias, # requires python>=3.9, e.g. for dict[...]
missing-function-docstring,
missing-module-docstring
1 change: 1 addition & 0 deletions location_guessing_game_telegram_bot/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def __str__(self) -> str:

@classmethod
def from_wikimap_export(cls, data: dict) -> _Photo:
# pylint: disable=consider-ternary-expression; easier to read
if isinstance(data["coordinates"], list):
coords = data["coordinates"][0]
else:
Expand Down
1 change: 1 addition & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import pytest

# pylint: disable=import-private-name; tests
from location_guessing_game_telegram_bot import _Photo


Expand Down
1 change: 1 addition & 0 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import pytest

# pylint: disable=import-private-name; tests
from location_guessing_game_telegram_bot import _main


Expand Down
1 change: 1 addition & 0 deletions tests/test_photo.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import pytest

# pylint: disable=import-private-name; tests
from location_guessing_game_telegram_bot import _Photo


Expand Down
1 change: 1 addition & 0 deletions tests/test_photo_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import logging
import unittest.mock

# pylint: disable=import-private-name; tests
from location_guessing_game_telegram_bot import _photo_command


Expand Down
1 change: 1 addition & 0 deletions tests/test_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import unittest.mock

# pylint: disable=import-private-name; tests
from location_guessing_game_telegram_bot import _run


Expand Down

0 comments on commit d551dd4

Please sign in to comment.