-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a default external enumeration library #456
Conversation
Looks good to me, so once the checkstyle issue is fixed, happy to merge. |
Thanks, but indeed all checks failed, so have to fix style and maybe other things. |
BTW this pull request moves the extenum API from the fplll namespace to the main namespace What are your thoughts on this:
|
TBH, I don't have a strong opinion either way. What's the risk of name collision in some bigger project, i.e. should it be in some namespace? |
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 64.74% 64.73% -0.01%
==========================================
Files 75 75
Lines 7432 7433 +1
==========================================
Hits 4812 4812
- Misses 2620 2621 +1
Continue to review full report at Codecov.
|
@malb do you want to push the green button? |
With pleasure. |
This PR makes it possible to directly integrate any external enumeration into fplll and be used by default by fplll.