Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird Rendering glitch when applying OSD Overlay. #289

Open
keggyhander opened this issue Feb 27, 2023 · 24 comments
Open

Weird Rendering glitch when applying OSD Overlay. #289

keggyhander opened this issue Feb 27, 2023 · 24 comments
Labels
overlay support

Comments

@keggyhander
Copy link

I thought there was something wrong with my Caddx Vista when I was getting weird glitches in my videos. It was only when I compared the raw video with the ones that had had the OSD rendered in that I noticed the source of the glitch was your software process. Here's a video showing the glitch: https://youtu.be/Oum5dfal44M

Here's a video in split screen showing raw video against the OSD-overlaid version:
https://www.youtube.com/watch?v=z6U-QKHOX0k

I would like to solve this because I like the look of my particular OSD

Cheers
@FinalFrag
Copy link
Contributor

Can you upload the original file, the .osd file and the fonts used?

@keggyhander
Copy link
Author

https://mega.nz/folder/QPJ0TB6B
key:DGpuaAjlUxuXYCDFkCdTwA

@keggyhander
Copy link
Author

keggyhander commented Feb 27, 2023 via email

@FinalFrag
Copy link
Contributor

The output video looks good when I run it through the osd-overlay that is currently on the develop branch. Could you try it again? If the issue is still there, what machine are you running it on? PC/Mac/MacM1?

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@keggyhander
Copy link
Author

Tried it again from here: https://knifa-develop.fpv.wtf/osd-overlay
If anything it was even worse than before.
What is this develop branch you speak of?

@FinalFrag
Copy link
Contributor

I forgot the current development branch has not been released publicly yet. Nevermind that.

I ran your files through that version as well, and they come out ok. Must be something specific about your setup. Could you try another browser and see if that has any effect? What browser did you use now?

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@stylesuxx
Copy link
Collaborator

The develop branch is actually being automatically deployed to https://develop.fpv.wtf/

@keggyhander
Copy link
Author

Losing patience with this now. If it doesn't work in chrome, what use is it, really?

@stylesuxx
Copy link
Collaborator

Alright, if you don't want help and don't have time to invest, feel free not to use it.

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@stylesuxx
Copy link
Collaborator

Well, you are being pretty entitled. You think we just snap our fingers and things get resolved magically? We ask questions and hope to drill down where the issue is coming from. If we could reproduce the issues on our end, we would not need to ask those questions.

We put a lot of our SPARE time and energy into this and the only thing we ask in return is to treat us with a minimum amount of respect. No need to get inpatient here.

Since you are on Windows you could for example try it on Edge. If at all possible you could also try it on a different machine. Please also post exact version of Chrome you are using.

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@FinalFrag
Copy link
Contributor

FinalFrag commented Mar 1, 2023 •
edited
Loading

I'm running the same version of chrome as you do. I also tried it in edge. Both result in no glitches.

At this point, I have no idea what is at the heart of this problem.

I have seen glitching before in my own files that were edited, but never in files straight from the goggles. I analysed your file and it has all the correct info in it that it should process fine.

I need to be able to reproduce the issue on my own machine before I can start digging. I'm gonna try to set up a clean install of windows in a virtual machine tomorrow, see if that makes a difference.

When you re-run the files in the same browser, do the glitches always appear in the same spots or is it random?

Are you doing anything else with the pc while the process is running or are you just waiting with the browser window in the foreground?

@keggyhander
Copy link
Author

keggyhander commented Mar 1, 2023 via email

@j005u
Copy link
Contributor

j005u commented Apr 14, 2023

This sounds very likely related to some combination of Chrome and your graphics cards drivers or something along those lines messing up. The support is relatively new and not that robust yet on all devices.

Updating GPU drivers could maybe possibly help. @Knifa is there an easy way to force CPU encoding, to give that try instead? Presuming Chrome defaults to GPU.

PS: Next time, if you want help, please refrain from using statements like "loosing patience" indeed. It works for 99%+ of users. Chrome WebCodecs do indeed have weird edge case bugs depending on the rest of your software/hardware, which are entirely Google's bugs. We do our best to work through them as they come up and solve them if we can. When we have the spare time to do so, completely for free.

So please consider what amount of patience and effort it takes from the devs before taking out your frustration here.

Hope we're able to get you sorted in the end.

@preisedj
Copy link

Same here. https://youtu.be/pXApHgllCmA

@FinalFrag
Copy link
Contributor

Same here. https://youtu.be/pXApHgllCmA

Could you upload the source files somewhere?

@preisedj
Copy link

Here are the files I'm working with. My flight controller is using Ardupilot, but I have the same results using INav.

https://drive.google.com/drive/folders/1hoAYZ6wh9drOr3gKww1oy9TIsraoYH_x?usp=sharing

@j005u
Copy link
Contributor

j005u commented Sep 27, 2023

@preisedj the fonts you provided on google drive are Betaflight fonts. Please see the issue you opened for the correct font name pattern you should be looking for.

@preisedj
Copy link

preisedj commented Sep 27, 2023 •
edited
Loading

@preisedj the fonts you provided on google drive are Betaflight fonts. Please see the issue you opened for the correct font name pattern you should be looking for.

Thank you!!! I finally found the right font to use. It was a bit confusing trying to distinguish between the various fonts on GitHub and other sites and whether they work for INAV or Ardupilot but I finally found the winning combination.
Thank you for your quick response and solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
overlay support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@j005u @stylesuxx @preisedj @FinalFrag @keggyhander