Recognize new names for Xbox Console Companion #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there anyway to test yr changes? |
|
You can check out the code here https://github.com/Ignefolio/XboxKeyboardMous and run it in Visual Studio. |
DavidRieman
requested changes
Jun 29, 2019
|
|
||
| var name = UWPUtils.GetProcessName(handle); | ||
|
|
||
| if (!name.EndsWith("XboxApp.exe") && started) |
There was a problem hiding this comment.
Sometimes, while switching between applications/windows, GetForegroundWindow can return a handle of 0. GetProcessName then returns null, and the following null.EndsWith crashes the application. We need null safety on name, and should probably skip the GetProcessName work when handle is 0 as well.
kiwioGIT
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses process id to find the name of the running process executable.
e.g.
C:\Program Files\WindowsApps\Microsoft.XboxApp_48.54.3003.0_x64__8wekyb3d8bbwe\XboxApp.exe
and relies for detection on the name of the executable(this should be the same in any language)
feel free to check for your self.