Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conference setttings nav fails on invalid acro #512

Closed
elad-eyal opened this issue Aug 25, 2019 · 0 comments · Fixed by #672
Closed

conference setttings nav fails on invalid acro #512

elad-eyal opened this issue Aug 25, 2019 · 0 comments · Fixed by #672

Comments

@elad-eyal
Copy link
Collaborator

elad-eyal commented Aug 25, 2019 •
edited

This is related to #504 but not caused by it I think.

  1. Create a conference.
  2. Enter the conference setting screen.
  3. Modify the conference acronym to be invalid by adding an uppercase letter, or a space.
  4. Click "Update Conference"
  5. You get "Acronym is invalid". so far so good.
  6. Click Days or Tracks or Rooms or Schedule or Classifiers or Notifications from the tabs bar.
  7. You get "The page you were looking for doesn't exist." :-(

The URL being navigated to includes the new, invalid acronym, and not the valid, unchanged one.
elad-eyal added a commit to elad-eyal/frab that referenced this issue Nov 23, 2019
@elad-eyal
fix frab#512
3b1db2b
elad-eyal added a commit to elad-eyal/frab that referenced this issue Nov 23, 2019
@elad-eyal
fix frab#512
3ad309e 
this is partial: It fixes the conferene settings tabs and the "Submit"
button; but the main tabs (top nav menu) are still not working. I'm
pretty sure there should be a better solution.
elad-eyal added a commit to elad-eyal/frab that referenced this issue Nov 24, 2019
@elad-eyal
fix frab#512
0ce1fc4
@elad-eyal elad-eyal mentioned this issue Feb 1, 2020
Merged
elad-eyal added a commit to elad-eyal/frab that referenced this issue Feb 15, 2020
@elad-eyal
fix frab#512
8af6bfe
elad-eyal added a commit to elad-eyal/frab that referenced this issue Jul 12, 2020
@elad-eyal
fix frab#512
b4a151f
elad-eyal added a commit to elad-eyal/frab that referenced this issue Jul 12, 2020
@elad-eyal
fix frab#512
89a2642
elad-eyal added a commit to elad-eyal/frab that referenced this issue Jul 12, 2020
@elad-eyal
fix frab#512
6e83f87
elad-eyal added a commit to elad-eyal/frab that referenced this issue Jul 15, 2020
@elad-eyal
fix frab#512
38add43
elad-eyal added a commit to elad-eyal/frab that referenced this issue Sep 16, 2020
@elad-eyal
fix frab#512
866d28b
elad-eyal added a commit that referenced this issue Oct 8, 2020
@elad-eyal
fix #512 (#672)
6e79e4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix frab#512 elad-eyal/frab
1 participant
@elad-eyal