Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk edit #582

Merged
merged 5 commits into from Nov 27, 2020
Merged

Bulk edit #582

merged 5 commits into from Nov 27, 2020

Conversation

elad-eyal
Copy link
Collaborator

@elad-eyal elad-eyal commented Oct 9, 2019 •
edited

batch editing for events - see #581

@elad-eyal elad-eyal force-pushed the bulk_edit branch 5 times, most recently from 49e07ab to 88e05d8 Compare October 14, 2019 13:28
@elad-eyal elad-eyal force-pushed the bulk_edit branch 4 times, most recently from f5e83a0 to 896336e Compare October 27, 2019 13:41
@elad-eyal elad-eyal closed this Oct 28, 2019
@elad-eyal elad-eyal reopened this Oct 28, 2019
@elad-eyal elad-eyal force-pushed the bulk_edit branch 4 times, most recently from 81a875c to bb17e46 Compare November 7, 2019 16:22
@elad-eyal
Copy link
Collaborator Author

elad-eyal commented Nov 9, 2019 •
edited

Updated the interface to be modal.

This should fix the problem of slowing down the event list screen.

We can fix the person selection & filter to be faster later.

image

image

image

image

image

image

@elad-eyal elad-eyal mentioned this pull request Nov 9, 2019
Closed
@elad-eyal elad-eyal force-pushed the bulk_edit branch 2 times, most recently from aa8536a to b3e55a9 Compare November 10, 2019 20:15
@elad-eyal
Copy link
Collaborator Author

I think this is ready for merge now. Maybe @erdgeist can translate 'Edit %{count} event:' inside de.yml; apparently google translate can't think on something better.

@erdgeist
Copy link
Contributor

I still find the model dialogue visually displeasing. Would you accept a commit trying to tidy up the interface?

@elad-eyal
Copy link
Collaborator Author

Sure

@elad-eyal
Copy link
Collaborator Author

added bulk editing for event duration. (i.e., change all events from 45min to 40min)

image

@elad-eyal
Copy link
Collaborator Author

elad-eyal commented Nov 27, 2019 •
edited

If and when #670 is merged I will change this to use AJAX-based person filter too.

@elad-eyal
Copy link
Collaborator Author

Hi @erdgeist. If the ui still displeased you, you can provide a mock up for how you think it should look and I'll try to implement that.

@elad-eyal elad-eyal force-pushed the bulk_edit branch 3 times, most recently from 4921389 to 2a069b1 Compare July 12, 2020 14:34
@elad-eyal
Copy link
Collaborator Author

I can accept that this is not the best UI for the mission and I'm open for feedback and implementing change. Barring that I think the capability to edit multiple events instead of one by one individually is important and helpful and I would want to see it merged.

@elad-eyal
Copy link
Collaborator Author

Hi @erdgeist, @manno - would you like to review this? TIA

saerdnaer
saerdnaer approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@saerdnaer saerdnaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elad-eyal elad-eyal merged commit b5b3bb0 into frab:master Nov 27, 2020
@elad-eyal elad-eyal deleted the bulk_edit branch November 27, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdgeist erdgeist erdgeist left review comments

@saerdnaer saerdnaer saerdnaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elad-eyal @erdgeist @saerdnaer