Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes for prod #756

Merged
merged 10 commits into from Dec 15, 2020
Merged

Hotfixes for prod #756

merged 10 commits into from Dec 15, 2020

Conversation

manno
Copy link
Member

@manno manno commented Dec 5, 2020

No description provided.

Ideally frab would have switched to activestorage.
This should get rid of warnings for now.

#434
@elad-eyal
Copy link
Collaborator

elad-eyal commented Dec 5, 2020

Env vars must be lowercase true in order to be admitted? Also some documentation would be nice.

@manno manno force-pushed the hotfixes-for-prod branch 3 times, most recently from 48ef041 to c1c7c60 Compare December 5, 2020 19:38
@manno
Copy link
Member Author

manno commented Dec 5, 2020

I added some docs to the env.example file. I'm just doing this to get rid of a (too) complicated deployment branch.

I'm not too happy with the optional gem group support in Rails.

@manno manno merged commit bb38f21 into master Dec 15, 2020
@manno manno deleted the hotfixes-for-prod branch December 15, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants