New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfixes for prod #756
Merged
Merged
Hotfixes for prod #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
force-pushed
the
hotfixes-for-prod
branch
from
December 5, 2020 16:17
71d9c44
to
fcd7ecb
Compare
Ideally frab would have switched to activestorage. This should get rid of warnings for now. #434
manno
force-pushed
the
hotfixes-for-prod
branch
from
December 5, 2020 17:07
73d7633
to
fb751d6
Compare
Env vars must be lowercase true in order to be admitted? Also some documentation would be nice. |
manno
force-pushed
the
hotfixes-for-prod
branch
3 times, most recently
from
December 5, 2020 19:38
48ef041
to
c1c7c60
Compare
I added some docs to the env.example file. I'm just doing this to get rid of a (too) complicated deployment branch. I'm not too happy with the optional gem group support in Rails. |
Some deployments do not track gender and do not have valid data for existing speakers This should probably hide gender stats and such
manno
force-pushed
the
hotfixes-for-prod
branch
from
December 5, 2020 20:00
133e3d5
to
d7622b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.