Upgrade to Rails 6.1 and Ruby 3.0.2 #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manno the sqlite CI failure can be removed by changing The idea of that part of the test is - we check we can rollback a few DB migrations, then migrate, and we want to verify that the identical schema was reached ( It seems something changed - the offending migrations did not change, and they had So I'm not 100% if this reveals a real problem; but anyway it's a specific test for validating migrations, and those surely did not become any worse. changing |
manno
force-pushed
the
rails6
branch
4 times, most recently
from
cc1f658
to
bead189
Compare
manno
force-pushed
the
rails6
branch
3 times, most recently
from
cd503df
to
522a7ea
Compare
* capybara spec changes
Fixed: > Disable compile cache if Ruby 3.0.3's ISeq cache bug is detected. AKA iseq.rb:13 to_binary: wrong argument type false (expected Symbol)
Previously we assumed that `db/schema.rb` is database agnostic. This is not exactly true in all regards. * rails/rails#26209 (comment) Our commited `schema.rb` can be used to `db:setup` all databases. running `db:schema:dump` or `db:migrate`, will turn the file into a database specific one. Formerly that wasn't obvious with the sqlite adapter, but now it dumps foreign key information into the schema. The previous check cannot be used anymore. This is unfortunate, since frab's migrations are so old, that you cannot `db:create db:migrate` a fresh system. Not sure if related, but we will probably see more problems with old frab installations on MySQL, due to the 2016 bigint change. These become especially problematic, when using foreign key constraints: * (MySQL switched to bigint)[rails/rails#26266] * rails/rails#43168 Changing all IDs and references to bigint on MySQL is probably not possible from migrations and should be done by the admin. A more extensive solution than this is needed: #660 (comment)
* this drops database_cleaner, the default transactional tests work fine * don't fail-fast the github actions matrix, so we now if it's a database related failure * frab test event title doesn't contain database id, multiply by 3 to avoid flakes in filter tests * editing_event_people_test waits for hidden field to change * turn on parallelized tests, one can set PARALLEL_WORKERS for more workers
elad-eyal
reviewed
Dec 27, 2021
The quotes are needed, because YAML parses the value to a number. This turns the 3.0 into a 3, which leads to the installation of Ruby 3.1. Howver gems (github-markdown?) are not ready for 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have time to pursue this at the moment.