Fixed extension to work with latest Chrome extension standards and replaced deprecated code. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urity differences. Still doesn't show up on the toolbar, though.
…anged background page persistence to true. Made separate popup.js file. Made popup wider. Works in latest Chrome now.
|
Looks good, and thanks for refactoring the js out of the html. |
fracek
added a commit
that referenced
this pull request
Apr 29, 2013
Fixed extension to work with latest Chrome extension standards and replaced deprecated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for providing this extension. I wasn't able to get your version working in Chrome 26, so I made the appropriate modifications, and thought you might want to incorporate them back into your repository.
It works great now, and is much easier to use than Amazon's built-in link generators.