Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way to provide map object in mapping proxy #96

Merged
merged 9 commits into from
Feb 24, 2022
Merged

Change the way to provide map object in mapping proxy #96

merged 9 commits into from
Feb 24, 2022

Conversation

AlexShukel
Copy link
Contributor

No description provided.

@AlexShukel AlexShukel added the enhancement New feature or request label Feb 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/stocked.cjs.production.min.js 9.45 KB (+3.96% 🔺)
dist/stocked.esm.js 8.85 KB (+3.17% 🔺)

ArtiomTr
ArtiomTr requested changes Feb 22, 2022
View reviewed changes
Copy link
Member

@ArtiomTr ArtiomTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is cool, just some modification required 👍

src/typings/MappingProxy.ts Outdated Show resolved Hide resolved
src/typings/ProxyMap.ts Outdated Show resolved Hide resolved
src/typings/ProxyMap.ts Outdated Show resolved Hide resolved
src/typings/ProxyMapSource.ts Outdated Show resolved Hide resolved
src/utils/areProxyMapsEqual.ts Outdated Show resolved Hide resolved
src/utils/areProxyMapsEqual.ts Outdated Show resolved Hide resolved
src/utils/createProxyMap.ts Outdated Show resolved Hide resolved
src/utils/createProxyMap.ts Outdated Show resolved Hide resolved
test/typings/MappingProxy.test.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@ArtiomTr ArtiomTr merged commit 4e3fb03 into main Feb 24, 2022
@ArtiomTr ArtiomTr deleted the change-the-way-to-provide-map-object-in-MappingProxy branch February 24, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtiomTr ArtiomTr ArtiomTr approved these changes

Assignees

@ArtiomTr ArtiomTr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexShukel @ArtiomTr