Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fix #1445 (do not include dataset history in dataset_dump) #1450

Closed
tcompa opened this issue Apr 30, 2024 · 0 comments · Fixed by #1453
Closed

Backport fix #1445 (do not include dataset history in dataset_dump) #1450

tcompa opened this issue Apr 30, 2024 · 0 comments · Fixed by #1453
Assignees
@ychiucco
Labels
bug Something isn't working

Comments

@tcompa
Copy link
Collaborator

tcompa commented Apr 30, 2024

It turns out we are populating jobv2.dataset_dump.images. Note that this does not appear in the API responses, since DatasetDumpV2 is written correctly (that is, it does not have a images attribute). But data are still written to the jobv2 table, thus making any operation with this table much slower.
(#1442)

We found this issue for datasetv2.images, but it also applies to datasetv2.history (now fixed in #1445).
This means that also fractal-server 1.x is affected, because applyworkflow.dataset_dump includes the history properties. Let's backport the fix in #1445 to the V1 apply-workflow endpoint.
@tcompa tcompa added the bug Something isn't working label Apr 30, 2024
tcompa added a commit that referenced this issue Apr 30, 2024
@tcompa
Exclude dataset history from applyworkflow (close #1450)
73c21f9 
This concerns `input_dataset_dump` and `output_dataset_dump` attributes
@tcompa tcompa linked a pull request Apr 30, 2024 that will close this issue
Exclude dataset history from applyworkflow (close #1450) #1453
Merged
2 tasks
tcompa added a commit that referenced this issue Apr 30, 2024
@tcompa
Merge pull request #1453 from fractal-analytics-platform/1450-backpor…
8c8f977 
…t-fix-1445-do-not-include-dataset-history-in-dataset_dump

Exclude dataset `history` from `applyworkflow` (close #1450)
tcompa added a commit that referenced this issue Jun 4, 2024
@tcompa
Exclude dataset history from applyworkflow (close #1450)
2e5ed40 
This concerns `input_dataset_dump` and `output_dataset_dump` attributes
tcompa added a commit that referenced this issue Jun 4, 2024
@tcompa
Merge pull request #1453 from fractal-analytics-platform/1450-backpor…
accbf37 
…t-fix-1445-do-not-include-dataset-history-in-dataset_dump

Exclude dataset `history` from `applyworkflow` (close #1450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ychiucco ychiucco

Labels
bug Something isn't working
Projects
Fractal Project Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude dataset history from applyworkflow (close #1450) fractal-analytics-platform/fractal-server
2 participants
@tcompa @ychiucco