Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid extras in DumpV2 models and cleanup benchmarks #1445

Merged
merged 23 commits into from Apr 30, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Apr 30, 2024

closes #1444

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Apr 30, 2024 that may be closed by this pull request
@ychiucco ychiucco changed the title Forbid extras in DumpV2 models Forbid extras in DumpV2 models Apr 30, 2024
@tcompa tcompa changed the title Forbid extras in DumpV2 models Forbid extras in DumpV2 models and cleanup benchmarks Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Benchmark comparison

Current branch: current-branch

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 1.1 0.9 1.22 0.0 0.0
power 1.1 0.9 1.22 0.0 0.0
dataset 1.1 0.9 1.22 0.0 0.0
project 1.1 0.9 1.22 0.0 0.0
job 1.1 0.9 1.22 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 10.2 1.02 0.7 0.7
power 382.3 380.8 1.00 440.2 440.2
dataset 156.7 152.7 1.03 171.2 171.2
project 48.2 47.9 1.01 58.9 58.9
job 31.6 31.7 1.00 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.1 7.4 0.96 2.4 2.4
power 136.8 134.3 1.02 688.6 688.6
dataset 138.5 169.1 0.82 982.0 982.0
project 45.0 50.5 0.89 307.8 307.8
job 39.3 79.8 0.49 243.8 243.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.1 8.1 1.00 0.1 0.1
power 8.0 7.8 1.03 0.1 0.1
dataset 8.0 7.8 1.03 0.1 0.1
project 10.3 10.0 1.03 2.3 2.3
job 8.0 8.0 1.00 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.7 11.7 1.00 0.8 0.8
power 25.3 24.8 1.02 29.8 29.8
dataset 19.3 19.1 1.01 17.1 17.1
project 22.8 24.8 0.92 21.5 21.5
job 11.1 11.1 1.00 0.9 0.9

POST /api/v2/project/3/dataset/403/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 149.3 154.8 0.96 275.1 275.1

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/schemas/v2
  dumps.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa deleted the 1444-forbid-extra-attributes-in-dump-models-v2 branch April 30, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid extra attributes in Dump models (v2)
2 participants