Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pydantic input schemas to core #437

Closed
jluethi opened this issue Jun 20, 2023 · 3 comments · Fixed by #438
Closed

Move pydantic input schemas to core #437

jluethi opened this issue Jun 20, 2023 · 3 comments · Fixed by #438

Comments

@jluethi
Copy link
Collaborator

jluethi commented Jun 20, 2023

To encourage broader usage of our Pydantic schemas and avoid that each task defines its own schema (e.g. for input channels), we should move all the pydantic schemas to the core part.

Then, I can depend on fractal-tasks-core (without tasks) also e.g. for the scMultipleX task
tcompa added a commit that referenced this issue Jun 20, 2023
@tcompa
Move input Pydantic models to main package (close #437)
5ef3be2
@tcompa tcompa linked a pull request Jun 20, 2023 that will close this issue
Move input Pydantic models to main package (close #437) #438
Merged
tcompa added a commit that referenced this issue Jun 20, 2023
@tcompa
Merge pull request #438 from fractal-analytics-platform/437-move-pyda…
cf6981f 
…ntic-input-schemas-to-core

Move input Pydantic models to main package (close #437)
@tcompa
Copy link
Collaborator

tcompa commented Jun 20, 2023

Available in 0.10.0a5

@tcompa
Copy link
Collaborator

tcompa commented Jun 20, 2023

(see lib_channels.py, for OmeroChannel and Window, and lib_input_models.py for the others)

@jluethi
Copy link
Collaborator Author

jluethi commented Jun 20, 2023

Awesome, thanks Tommaso! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tcompa @jluethi