Cleanup and fix build failures in reserved project names PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default gradle makes sure that project names are unique inside a build. Since Eclipse supports multiple projects inside a workspace this can still lead to conflicts. With this change we send the list of non-build related project names to gradle so it can exclude those during name generation. This change fixes the import of gradle projects that have no existing conflicting .project files Signed-off-by: Christian Fraenkel <christian-ec@fraenkel.net>
Signed-off-by: Christian Fraenkel <christian-ec@fraenkel.net>
…/buildship into fraenkelc-reserved_project_names
|
I've rebased my pr and cherrypicked your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.