Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid SIGSEGV on decoding 8bit char filenames on NetBSD/amd64. #33

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

tsutsui
Copy link
Contributor

@tsutsui tsutsui commented Nov 16, 2020

Both 'path' and 'filename' members are defined as (char *) so 8bit character (ancient Japanese Shift_JIS etc.) in filenames is treated as a negative value and casting such a negative value to (unsigned) generates an unexpected large value.

@sezero
Copy link
Contributor

sezero commented Sep 25, 2022

Is there a reason that this patch is not applied?

@fragglet fragglet merged commit 60c4e23 into fragglet:master Sep 26, 2022
@fragglet
Copy link
Owner

No reason. Thanks!

@tsutsui tsutsui deleted the fix-sigsegv-8bit-filenames branch September 28, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants