Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bg: fix panic when request body is a string #1992

Merged
merged 2 commits into from
May 7, 2024
Merged

bg: fix panic when request body is a string #1992

merged 2 commits into from
May 7, 2024

Conversation

olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented May 3, 2024 •
edited 

change adds support for string request body in the flatten method.

Screenshot 2024-05-03 at 16 09 14

@CLAassistant
Copy link

CLAassistant commented May 3, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@jirevwe
Copy link
Collaborator

jirevwe commented May 3, 2024

Can you add some test cases for this?

@olamilekan000
Copy link
Contributor Author

Can you add some test cases for this?

done

@olamilekan000 olamilekan000 force-pushed the fix-panic-when-event-create-req-body-is-a-string branch from 677e7f9 to 3eddbd6 Compare May 3, 2024 19:52
@jirevwe jirevwe merged commit 2039a86 into frain-dev:main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirevwe jirevwe jirevwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olamilekan000 @CLAassistant @jirevwe