Update rate limit function #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subomi
reviewed
May 14, 2024
subomi
reviewed
May 14, 2024
subomi
reviewed
May 15, 2024
subomi
approved these changes
May 22, 2024
Oluwadaminiola
pushed a commit
that referenced
this pull request
May 22, 2024
* chore: update rate limit function * fix: return when locked row is null * fix: select only specific rows * chore: create record if not exists
jirevwe
added a commit
that referenced
this pull request
May 27, 2024
* added metrics for the data plane (#2005) * added metrics for the data plane * updated docker-compose.dev.yml with optional prometheus image * updated RedisQueue as a metrics collector * updated postgres as a metrics collector * revert error check in process_meta_event.go * updated metrics collection for different http status codes * updated postgres_collector.go * fixed lint issues and updated some queries * updated metrics to be configurable * updated test config * fixed failing CI tests * gated metrics with feature flags * fixed CI issues * updated metrics tests * refactored postgres_collector.go * Update rate limit function (#2002) * chore: update rate limit function * fix: return when locked row is null * fix: select only specific rows * chore: create record if not exists * Add subscription name filter to GetSubscriptions (#2014) * fix: add subscription name filter to GetSubscriptions * fix: add % directly in arg map * fix: add portal link checks to subscription apis * fix: remove isPortaLinkReq * fix: use util.StringSliceContains * fix: revert envs * fix: check if data.FilterBy.EndpointIDs was present before setting it --------- Co-authored-by: Smart Mekiliuwa <st.nonso@gmail.com> Co-authored-by: Raymond Tukpe <jirevwe@users.noreply.github.com> Co-authored-by: Pelumi Muyiwa-Oni <Pelumioni25@gmail.com>
jirevwe
added a commit
that referenced
this pull request
May 27, 2024
* add subscriptions list and form to portal links * update endpoints dropdown * added metrics for the data plane (#2005) * added metrics for the data plane * updated docker-compose.dev.yml with optional prometheus image * updated RedisQueue as a metrics collector * updated postgres as a metrics collector * revert error check in process_meta_event.go * updated metrics collection for different http status codes * updated postgres_collector.go * fixed lint issues and updated some queries * updated metrics to be configurable * updated test config * fixed failing CI tests * gated metrics with feature flags * fixed CI issues * updated metrics tests * refactored postgres_collector.go * Update rate limit function (#2002) * chore: update rate limit function * fix: return when locked row is null * fix: select only specific rows * chore: create record if not exists * Add subscription name filter to GetSubscriptions (#2014) * fix: add subscription name filter to GetSubscriptions * fix: add % directly in arg map * add search for subscriptions on portal links * update route for subscriptions * move abd update portal link layout * delete apps module * fix and update subscriptions form * update subscriptions/endpoints page * fix endpoint search * Add portal link checks to subscription apis (#2016) * added metrics for the data plane (#2005) * added metrics for the data plane * updated docker-compose.dev.yml with optional prometheus image * updated RedisQueue as a metrics collector * updated postgres as a metrics collector * revert error check in process_meta_event.go * updated metrics collection for different http status codes * updated postgres_collector.go * fixed lint issues and updated some queries * updated metrics to be configurable * updated test config * fixed failing CI tests * gated metrics with feature flags * fixed CI issues * updated metrics tests * refactored postgres_collector.go * Update rate limit function (#2002) * chore: update rate limit function * fix: return when locked row is null * fix: select only specific rows * chore: create record if not exists * Add subscription name filter to GetSubscriptions (#2014) * fix: add subscription name filter to GetSubscriptions * fix: add % directly in arg map * fix: add portal link checks to subscription apis * fix: remove isPortaLinkReq * fix: use util.StringSliceContains * fix: revert envs * fix: check if data.FilterBy.EndpointIDs was present before setting it --------- Co-authored-by: Smart Mekiliuwa <st.nonso@gmail.com> Co-authored-by: Raymond Tukpe <jirevwe@users.noreply.github.com> Co-authored-by: Pelumi Muyiwa-Oni <Pelumioni25@gmail.com> * check option name in select component * fix portal links form * remove comments --------- Co-authored-by: Smart Mekiliuwa <st.nonso@gmail.com> Co-authored-by: Raymond Tukpe <jirevwe@users.noreply.github.com> Co-authored-by: Daniel Oluojomu <danvixent@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the CPU usage of the
convoy.take_token()function.