Feature/api extractor #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is generated into the dist folder now
mattgperry
approved these changes
Feb 11, 2019
aron
approved these changes
Feb 11, 2019
| @@ -56,6 +56,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@emotion/is-prop-valid": "^0.7.3", | |||
| "@microsoft/api-extractor": "^7", | |||
There was a problem hiding this comment.
Lets tag this at 7.0.13 to ensure the output is the same as Library.
There was a problem hiding this comment.
But that should be in the yarn.lock, right? I'll make sure that will say 7.0.13, because I think it's at 17 now
| scrollYProgress: import(".").MotionValue<number> | ||
| } | ||
|
|
||
| // (No @packageDocumentation comment for this package) |
There was a problem hiding this comment.
Is this everything? Feels a little incomplete...
There was a problem hiding this comment.
Ah, this was everything api-extractor was complaining about, but I will double check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now generates:
And:
@aron can you verify that this is what we actually need?