Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subsequent loads 404 broken #40

Closed
arctic-hen7 opened this issue Oct 1, 2021 · 1 comment
Closed

Subsequent loads 404 broken #40

arctic-hen7 opened this issue Oct 1, 2021 · 1 comment
Assignees
@arctic-hen7
Labels
A-router Area: router C-bug Category: bug D-easy Difficulty: easy P-high Priority: high S-in-development Status: in development

Comments

@arctic-hen7
Copy link
Member

Describe the bug
If a link in a Perseus app goes to a page that doesn't exist, no error page will be displayed. The URL will change, but nothing else will. This is due to a single semicolon I think, and appears to be unrelated to a similar bug in Sycamore routing.

To Reproduce
Steps to reproduce the behavior:

  1. Create a page with a link to a nonexistent page.
  2. Click the link.
  3. Observe that the URL changes, but no error is displayed.

Expected behavior
A 404 message should be displayed

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Perseus Version: v0.3.0-beta.1
  • Sycamore Version: v0.6.1
  • OS: Ubuntu
  • Browser: Firefox
  • Browser Version: 93

Additional context
Add any other context about the problem here.
@arctic-hen7 arctic-hen7 added C-bug Category: bug A-router Area: router D-easy Difficulty: easy P-high Priority: high S-in-development Status: in development labels Oct 1, 2021
@arctic-hen7 arctic-hen7 self-assigned this Oct 1, 2021
arctic-hen7 added a commit that referenced this issue Oct 1, 2021
@arctic-hen7
fix(routing): 🐛 fixed subsequent loads 404s
f8e05da 
Closes #40.
@arctic-hen7
Copy link
Member Author

This is fixed on the same branch as for fixing #39, so I'll release those two fixes together in v0.3.0-beta.2.

arctic-hen7 added a commit that referenced this issue Oct 1, 2021
@arctic-hen7
fix: 🐛 fixed build paths issues (#41)
532243e 
* fix(routing): 🐛 fixed subsequent loads 404s

Closes #40.

* fix(routing): 🐛 allowed build paths to generate root pages

* docs(book): 📝 updated docs on how to use build paths to generate root pages
arctic-hen7 added a commit that referenced this issue Oct 4, 2021
@arctic-hen7
chore: 🔀 merged from main for new beta version
4a7698f 
That fixes #39 and #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arctic-hen7 arctic-hen7

Labels
A-router Area: router C-bug Category: bug D-easy Difficulty: easy P-high Priority: high S-in-development Status: in development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arctic-hen7