Add Tokio #102
Merged
Add Tokio #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All plugin functions must now implement `Send`.
Magical compilation errors occur otherwise for some reason.
This should increase performance for templates with a very large number of pages, each generated path is now built concurrently.
I *think* this makes everything async, the main thing is just the file operations.
arctic-hen7
added
C-enhancement
Actix seems to introduce a breaking change in the deps tree on CI, though this hasn't been reported anywhere else. If people start having issues, I'll release an urgent patch.
This should hopefully fix the consistent breakages of `apt` on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Perseus doesn't do
asyncwell at all. There are some blocking I/O operations deep in the core, and any libraries that people want to pull into their builders that require a full runtime like Tokio will not work at all, because everything comes down to afutures::executor::block_onat present.This PR solves that issue by bringing in Tokio at the top level and making all core operations (particularly in the stores and translations manager systems) fully asynchronous. This should allow using more complex libraries and code in builder functions, and should also enable potentially large performance gains for apps that build many pages from a single template (as that is now all done in parallel). Additionally, this makes the Perseus server far more resilient and logical.
Astoundingly, none of this actually constitutes a breaking change, though plugin developers will have to ensure that their systems are
Sendable (which shouldn't pose a problem for most, and there's only one publicly available plugin in existence at present).