Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Transients not properly autowired on subsequent get #420
From what I have found, the issue is caused by the setters being called on
I fixed the issue by putting this code in
I'm not convinced that this is the correct fix though - smells very hacky - so haven't submitted a PR. I didn't have this issue with previous releases either, so I think the problem is caused elsewhere and my fix merely masks the issue.
Thanks @georgebridgeman -- that's actually very helpful. The reason this bug has appeared is the caching code added to try to avoid walking dependencies multiple times for transients by not forcing regeneration of the accumulator data, but this seems to be a path through where the newly generated transient needs to be overridden in the cache (although there's still a possibility of multiple transients generated in a single recursive resolution phase where only one of them would have setters called properly... that may be enough of an edge case not to worry about).