Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumped to 1.5.3. Added isAnimated param to toolbar #1282

Closed
wants to merge 1 commit into from
Closed

Version bumped to 1.5.3. Added isAnimated param to toolbar #1282

wants to merge 1 commit into from

Conversation

centrual
Copy link

Hello Vladimir,

I added isAnimated parameter to:

  • hideToolbar
  • showToolbar
  • hideNavbar
  • showNavbar

methods. When you pressed an input in phone, animation looks bad. Because of that, i added isAnimated parameter. Default is true, so everybody can use same as before.

I wrote changes to CHANGELOG.md ( with your virtual list update )

Have a great day!

@nolimits4web
Copy link
Member

Thanks, i merged it manually because of the following reasons:

  1. Version shouldn't be bumped
  2. Too much indent space (4 spaces instead of 2 for tab)
  3. I changed logic to contra verse. So if we don't pass new parameter, nothing should change, so no classes is added. And it adds "not-animated" class in case we pass "noAnimated" parameter

@centrual
Copy link
Author

Thank you Vladimir.

I will be careful.

Interestingly i using tab (2 spaces area) in webstorm but when i upload, it changes. I'll find why it is happening.

Have a great day!

@centrual centrual closed this Jan 19, 2017
@ZanderBrown ZanderBrown added this to Resolved in Bug Report Triage Jan 28, 2018
@lock
Copy link

lock bot commented Jun 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jun 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Bug Report Triage
  
Resolved
Development

Successfully merging this pull request may close these issues.

None yet

2 participants