Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Open panel/popup/login screen/tab without animation #1298

Closed
1 of 3 tasks
scriptPilot opened this issue Jan 18, 2017 · 7 comments
Closed
1 of 3 tasks

Comments

@scriptPilot
Copy link
Contributor

scriptPilot commented Jan 18, 2017

This is a (multiple allowed):

  • bug
  • enhancement
  • feature-discussion (RFC)

To restore the state after application reload, I search for a way to open panel, popup, login screen or tab without any delay or animation after page initialization. Is there any proper way to do so?

I figured out the following solution for popup, but so far no solution for login screen and side panels.

Popup: Manually, with removeClass('modal-out'), addClass('modal-in') and css('display', 'block')

Best way would be a parameter on openPanel(), popup() and loginScreen() functions.

Maybe there is already a good way?

@scriptPilot scriptPilot changed the title [Feature request] Open popup/login screen without animation [Feature request] Open panel/popup/login screen without animation Jan 18, 2017
@centrual
Copy link

I'll add this feature to #1282 soon...

@scriptPilot
Copy link
Contributor Author

Perfect! Could you propose any workaround for now?

@scriptPilot scriptPilot changed the title [Feature request] Open panel/popup/login screen without animation [Feature request] Open panel/popup/login screen/tab without animation Jan 19, 2017
@scriptPilot
Copy link
Contributor Author

noAnimated option would be fine as well for showTab()

@valnub
Copy link
Collaborator

valnub commented Jan 21, 2017

centrual's PR got merged.

@scriptPilot Did this solve the issue for you?

@centrual
Copy link

@valnub I didn't added this features to modals currently. I will make this feature request as soon as possible.

@scriptPilot
Copy link
Contributor Author

scriptPilot commented Jan 21, 2017

@valnub, @centrual I think not completely - the request was for everything what could be opened by script - so, on the list are for me:

  • side panels
  • popups
  • login screens
  • tabs
  • pages

I have integrated it in the runtime restoration for my open source project App Framework (see demo) - if you play there a little bit around, open for example a panel and reload the page, it will be restored, but with animation - I would like to do it without :-)

@scriptPilot
Copy link
Contributor Author

Works fine, thank you Vladimir

@ZanderBrown ZanderBrown added this to Resolved in Bug Report Triage Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Report Triage
  
Resolved
Development

No branches or pull requests

3 participants