Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color format from #argb to #rgba #70

Closed
francma opened this issue Mar 8, 2021 · 4 comments · Fixed by #79
Closed

Change color format from #argb to #rgba #70

francma opened this issue Mar 8, 2021 · 4 comments · Fixed by #79

Comments

@francma
Copy link
Owner

francma commented Mar 8, 2021

Most RGB with alpha color representations are in #RRGGBBAA format - for example

@francma francma added this to the wob 1.0 milestone Mar 8, 2021
@Brod8362
Copy link
Contributor

Brod8362 commented Mar 8, 2021

Additional idea - maybe make the alpha optional? Just default to fully opaque if not specified.

bretello added a commit to bretello/wob that referenced this issue Mar 14, 2021
bretello added a commit to bretello/wob that referenced this issue Mar 14, 2021
bretello added a commit to bretello/wob that referenced this issue Mar 14, 2021
@RicArch97
Copy link

Changing the colours to "#RRGGBB" and "#RRGGBBAA" would be a very welcome change. Would make it easier to pass along colors generated by PyWal for example.

@532910
Copy link

532910 commented May 28, 2021

I believe the color format should be <RRGGBB[AA]> instead of the current <#AARRGGBB>. The same as in swaynag for example

@FallenChromium
Copy link

Absolutely agree, if the RGB color is used as a variable, it will be possible to just add the opacity afterwards, and you can't do that (easily) with argb format, because there will be 2 # symbols. Though if anyone would share their solution to this problem it will be appreciated. I gave up trying to use my sway RGB variables as colors for wob because of that format mess.

boredland pushed a commit to boredland/wob that referenced this issue Jul 21, 2021
francma pushed a commit that referenced this issue Jul 21, 2021
fixes #70

Co-authored-by: bretello <bretello@distruzione.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants