Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parse_config_from_environment #71

Closed
wants to merge 3 commits into from
Closed

Conversation

bretello
Copy link

@bretello bretello commented Mar 14, 2021

  • add wob_parse_config_from_environment to parse configuration values from environment variables
  • add systemd units examples (wob.service reads configuration from environment from ~/.config/wob.conf)
  • use #RRGGBBAA syntax for colors instead of #AARRGGBBB (Change color format from #argb to #rgba #70)

I guess this will also requires patching the PKGBUILD in the archlinux's community repos to install the systemd units

@bretello
Copy link
Author

I'm guessing this also relates to #61

@francma
Copy link
Owner

francma commented Mar 14, 2021

add wob_parse_config_from_environment to parse configuration values from environment variables

There is already an issue regarding .ini file configuration #66. Parsing config from environment variables will get pretty messy once per output configuration is implemented (that also applies for cli options).

add systemd units examples (wob.service reads configuration from environment from ~/.config/wob.conf)

Looks good, please make a separate PR.

use #RRGGBBAA syntax for colors instead of #AARRGGBBB (#70)

Looks good, please make a separate PR.

@bretello
Copy link
Author

There is already an issue regarding .ini file configuration #66. Parsing config from environment variables will get pretty messy once per output configuration is implemented (that also applies for cli options).

Is there an active branch for this?

@francma
Copy link
Owner

francma commented Mar 1, 2022

Systemd service examples and changed color format are already merged in master.

Parsing from configuration files (which replaces this PR) is still work in progress in #78

@francma francma closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants