fix(core): call generateAutocompleteId only if necessary

francoischalifour · Feb 12, 2020 · ce4d496 · ce4d496
1 parent c647224
commit ce4d496
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/autocomplete-core/defaultProps.ts b/packages/autocomplete-core/defaultProps.ts
@@ -15,7 +15,6 @@ export function getDefaultProps<TItem>(
     : {}) as typeof window;
 
   return {
-    id: generateAutocompleteId(),
     minLength: 1,
     placeholder: '',
     autoFocus: false,
@@ -27,6 +26,9 @@ export function getDefaultProps<TItem>(
     onStateChange: noop,
     onSubmit: noop,
     ...props,
+    // Since `generateAutocompleteId` triggers a side effect (it increments
+    // and internal counter), we don't want to execute it if unnecessary.
+    id: props.id ?? generateAutocompleteId(),
     // The following props need to be deeply defaulted.
     initialState: {
       highlightedIndex: 0,