-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make img thumb and then load larger img #6
Comments
Hi, thank you for getting involved. Your issue is somehow related to #3 (they both aim at solving the same problem). I like your second solution better. My first view on this would be to:
(*) It might be more relevant to detect when the image is fully loaded instead of relying on the What's your view on this? |
Hi. Attaching a |
What would you need that class for? |
On second thought you're right, a class is not needed in this case. |
Fixed with #21. |
First of all thank you for the script. It is by far the best medium like zoom that I've seen, UX wise.
But the way it's structured with just one huge scaled image makes it bad for mobile and Google Page Speed does not like it at all.
How about changing the html structure so that a smaller image is displayed first and then load the high resolution image on click in the overlay? The thumb could be displayed big in the overlay until the high-res has loaded.
Something along the lines of
EDIT
Or using an attribute for the high res like so:
The text was updated successfully, but these errors were encountered: