Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make img thumb and then load larger img #6

Closed
onedrawingperday opened this issue Apr 27, 2017 · 5 comments
Closed

Make img thumb and then load larger img #6

onedrawingperday opened this issue Apr 27, 2017 · 5 comments

Comments

@onedrawingperday
Copy link

onedrawingperday commented Apr 27, 2017

First of all thank you for the script. It is by far the best medium like zoom that I've seen, UX wise.

But the way it's structured with just one huge scaled image makes it bad for mobile and Google Page Speed does not like it at all.

How about changing the html structure so that a smaller image is displayed first and then load the high resolution image on click in the overlay? The thumb could be displayed big in the overlay until the high-res has loaded.

Something along the lines of

<a class="medium-zoom-image" href="images/1-jumbo.jpg">
<img src="images/1.jpg" alt="Medium Zoom illustration" class="medium-zoom-thumb">
</a>

EDIT
Or using an attribute for the high res like so:

<img src="images/1.jpg" data-hd="images/1-jumbo.jpg" alt="Medium Zoom illustration" class="medium-zoom-thumb">
@onedrawingperday onedrawingperday changed the title Make img thumb and load larger img Make img thumb and then load larger img Apr 27, 2017
@francoischalifour
Copy link
Owner

francoischalifour commented May 3, 2017

Hi, thank you for getting involved. Your issue is somehow related to #3 (they both aim at solving the same problem).

I like your second solution better. My first view on this would be to:

  1. Load the data-hd URL on the event show (when the user clicks on the image)
  2. Set the src attribute to the data-hd's value on shown* (when the image is fully zoomed in)
  3. Reset the src attribute on hide or hidden (see which one is more coherent)

(*) It might be more relevant to detect when the image is fully loaded instead of relying on the shown event to not show a partial image. That means attaching a load event to the newly created data-hd image.

What's your view on this?

@onedrawingperday
Copy link
Author

Hi. Attaching a load event to data-hd looks good. Perhaps it would also be good to attach a class on the image after the load. e.g. loaded.

@francoischalifour
Copy link
Owner

What would you need that class for?

@onedrawingperday
Copy link
Author

On second thought you're right, a class is not needed in this case.

@francoischalifour
Copy link
Owner

Fixed with #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants